refactor(core/audio): eliminar 5 funcions mortes a Ja:: (DEAD-01..04, PATCH-04)
Verificat amb grep que cap caller dins de source/ invoca:
- Ja::setMusicPosition (stub no-op)
- Ja::getMusicPosition (stub que retornava 0)
- Ja::getMusicFilename (accessor a Music::filename, el camp s'accedeix
directament des d'Audio)
- Ja::getChannelState (getter sense consumidor públic)
- Ja::setVolume (combinació master — Audio fa el gate per canal)
Es manté loadMusic(buffer, length, filename) perquè Resource::Cache
l'utilitza per registrar el path dins del Ja::Music.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
355fcfb9de
commit
3089177e69
2 files changed
+8
-34
No files matched your search
@@ -318,8 +318,9 @@ namespace Ja {
|
||||
return music.release();
|
||||
}
|
||||
|
||||
// Overload amb filename — els callers l'usen per poder comparar la música
|
||||
// en curs amb getMusicFilename() i no rearrancar-la si ja és la mateixa.
|
||||
// Overload amb filename. Resource::Cache l'usa per registrar el path dins
|
||||
// del propi Ja::Music (camp `filename`); la capa Audio l'usa per recuperar
|
||||
// el nom després d'un playMusic(Ja::Music*, ...) — veure PATCH-02.
|
||||
inline auto loadMusic(const Uint8* buffer, Uint32 length, const char* filename) -> Music* {
|
||||
Music* music = loadMusic(buffer, length);
|
||||
if (music != nullptr && filename != nullptr) { music->filename = filename; }
|
||||
@@ -355,12 +356,6 @@ namespace Ja {
|
||||
}
|
||||
}
|
||||
|
||||
inline auto getMusicFilename(const Music* music = nullptr) -> const char* {
|
||||
if (music == nullptr) { music = current_music; }
|
||||
if (music == nullptr || music->filename.empty()) { return nullptr; }
|
||||
return music->filename.c_str();
|
||||
}
|
||||
|
||||
inline void pauseMusic() {
|
||||
if (!music_enabled) { return; }
|
||||
if (current_music == nullptr || current_music->state != MusicState::PLAYING) { return; }
|
||||
@@ -495,14 +490,6 @@ namespace Ja {
|
||||
return music_volume;
|
||||
}
|
||||
|
||||
inline void setMusicPosition(float /*value*/) {
|
||||
// No implementat amb el backend de streaming.
|
||||
}
|
||||
|
||||
inline auto getMusicPosition() -> float {
|
||||
return 0.0F;
|
||||
}
|
||||
|
||||
inline void enableMusic(const bool value) {
|
||||
if (!value && current_music != nullptr && (current_music->state == MusicState::PLAYING)) { stopMusic(); }
|
||||
music_enabled = value;
|
||||
@@ -613,13 +600,6 @@ namespace Ja {
|
||||
});
|
||||
}
|
||||
|
||||
inline auto getChannelState(const int channel) -> ChannelState {
|
||||
if (!sound_enabled) { return ChannelState::SOUND_DISABLED; }
|
||||
if (channel < 0 || channel >= MAX_SIMULTANEOUS_CHANNELS) { return ChannelState::INVALID; }
|
||||
|
||||
return channels[channel].state;
|
||||
}
|
||||
|
||||
inline auto setSoundVolume(float volume, const int group = -1) -> float {
|
||||
const float V = SDL_clamp(volume, 0.0F, 1.0F);
|
||||
|
||||
@@ -651,10 +631,4 @@ namespace Ja {
|
||||
sound_enabled = value;
|
||||
}
|
||||
|
||||
inline auto setVolume(float volume) -> float {
|
||||
const float V = setMusicVolume(volume);
|
||||
setSoundVolume(V, -1);
|
||||
return V;
|
||||
}
|
||||
|
||||
} // namespace Ja
|
||||
Reference in new issue
Block a user