useStlAlgorithm: ranges algorithms + justifica returnDanglingLifetime

source/game/entities/animation_component.cpp

@@ -1,6 +1,8 @@
 #include "game/entities/animation_component.hpp"
 
+#include <algorithm>
 #include <cmath>
+#include <iterator>
 #include <stdexcept>
 #include <utility>
 
@@ -33,8 +35,7 @@ namespace {
         if (speeds.empty()) {
             return std::vector<float>(frame_count, K_DEFAULT_FRAME_SECONDS);
         }
-        // cppcheck-suppress useStlAlgorithm
-        for (auto& s : speeds) { s = sanitizeSpeed(s); }
+        std::ranges::transform(speeds, speeds.begin(), sanitizeSpeed);
         if (speeds.size() == frame_count) { return speeds; }
         if (speeds.size() > frame_count) {
             speeds.resize(frame_count);
@@ -50,10 +51,7 @@ namespace {
     // component vàlid.
     auto parseFrames(const fkyaml::node& anim) -> std::vector<int> {
         std::vector<int> frames;
-        for (const auto& f : anim["frames"]) {
-            // cppcheck-suppress useStlAlgorithm
-            frames.push_back(f.get_value<int>());
-        }
+        std::ranges::transform(anim["frames"], std::back_inserter(frames), [](const fkyaml::node& f) { return f.template get_value<int>(); });
         if (frames.empty()) { frames.push_back(0); }
         return frames;
     }
@@ -66,10 +64,7 @@ namespace {
         std::vector<float> speeds_secs;
         const auto& fm = anim["frame_ms"];
         if (fm.is_sequence()) {
-            for (const auto& v : fm) {
-                // cppcheck-suppress useStlAlgorithm
-                speeds_secs.push_back(static_cast<float>(v.get_value<int>()) / 1000.0F);
-            }
+            std::ranges::transform(fm, std::back_inserter(speeds_secs), [](const fkyaml::node& v) { return static_cast<float>(v.template get_value<int>()) / 1000.0F; });
         } else {
             const float SECS = static_cast<float>(fm.get_value<int>()) / 1000.0F;
             speeds_secs.assign(frame_count, SECS);