jaildesigner-jailgames/coffee-crisis-ae
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 15 Wiki Activity

Mes recomanacions de cppcheck aplicades

Browse Source 
Abans de tocar unes cosetes de strings buits
This commit is contained in:
Sergio Valor
2024-10-13 13:49:00 +02:00
parent b2122ac239
commit 46b19ee82f
22 changed files with 995 additions and 1062 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/manage_hiscore_table.cpp
+11 -9
View File
@@ -50,25 +50,25 @@ void ManageHiScoreTable::sort()
{
struct
{
bool operator()(HiScoreEntry a, HiScoreEntry b) const { return a.score > b.score; }
bool operator()(HiScoreEntry &a, HiScoreEntry &b) const { return a.score > b.score; }
} custom_less;
std::sort(table_->begin(), table_->end(), custom_less);
}
// Carga la tabla con los datos de un fichero
bool ManageHiScoreTable::loadFromFile(std::string file_path)
bool ManageHiScoreTable::loadFromFile(const std::string &file_path)
{
clear();
auto success = true;
const std::string filename = file_path.substr(file_path.find_last_of("\\/") + 1);
auto file = SDL_RWFromFile(file_path.c_str(), "r+b");
if (file)
{
#ifdef VERBOSE
std::cout << "Reading file: " << filename.c_str() << std::endl;
const std::string file_name = file_path.substr(file_path.find_last_of("\\/") + 1);
std::cout << "Reading file: " << file_name.c_str() << std::endl;
#endif
for (int i = 0; i < (int)table_->size(); ++i)
{
@@ -86,7 +86,7 @@ bool ManageHiScoreTable::loadFromFile(std::string file_path)
break;
}
char *name = (char *)malloc(nameSize + 1);
char *name = static_cast<char *>(malloc(nameSize + 1));
if (SDL_RWread(file, name, sizeof(char) * nameSize, 1) == 0)
{
success = false;
@@ -113,10 +113,12 @@ bool ManageHiScoreTable::loadFromFile(std::string file_path)
}
// Guarda la tabla en un fichero
bool ManageHiScoreTable::saveToFile(std::string file_path)
bool ManageHiScoreTable::saveToFile(const std::string &file_path)
{
#ifdef VERBOSE
const std::string file_name = file_path.substr(file_path.find_last_of("\\/") + 1);
#endif
auto success = true;
const std::string fileName = file_path.substr(file_path.find_last_of("\\/") + 1);
auto file = SDL_RWFromFile(file_path.c_str(), "w+b");
if (file)
@@ -131,7 +133,7 @@ bool ManageHiScoreTable::saveToFile(std::string file_path)
}
#ifdef VERBOSE
std::cout << "Writing file: " << fileName.c_str() << std::endl;
std::cout << "Writing file: " << file_name.c_str() << std::endl;
#endif
// Cierra el fichero
SDL_RWclose(file);
@@ -139,7 +141,7 @@ bool ManageHiScoreTable::saveToFile(std::string file_path)
else
{
#ifdef VERBOSE
std::cout << "Error: Unable to save " << fileName.c_str() << " file! " << SDL_GetError() << std::endl;
std::cout << "Error: Unable to save " << file_name.c_str() << " file! " << SDL_GetError() << std::endl;
#endif
}
return success;