From 6b6d5f1f6dcc563e5824770b9f604c8896858dd6 Mon Sep 17 00:00:00 2001 From: Sergio Valor Date: Sun, 17 May 2026 19:51:11 +0200 Subject: [PATCH] neteja NOLINT obsolets (de 29 a 10) --- source/core/input/gamepad_config_manager.hpp | 4 ++-- source/core/input/pause_manager.hpp | 4 ++-- source/core/rendering/screen.cpp | 2 +- source/core/rendering/sdl3gpu/sdl3gpu_shader.cpp | 2 +- source/core/resources/resource_pack.cpp | 2 +- source/game/entities/player.cpp | 2 +- source/game/entities/player.hpp | 2 +- source/game/options.cpp | 8 ++++---- source/game/options.hpp | 8 ++++---- source/game/ui/menu_renderer.cpp | 2 +- source/game/ui/menu_renderer.hpp | 2 +- 11 files changed, 19 insertions(+), 19 deletions(-) diff --git a/source/core/input/gamepad_config_manager.hpp b/source/core/input/gamepad_config_manager.hpp index 24e7e4b..2119398 100644 --- a/source/core/input/gamepad_config_manager.hpp +++ b/source/core/input/gamepad_config_manager.hpp @@ -64,7 +64,7 @@ class GamepadConfigManager { // Escribir al archivo std::ofstream file(filename); if (!file.is_open()) { - return false; // NOLINT(readability-simplify-boolean-expr) + return false; } file << j.dump(4); // Formato con indentación de 4 espacios @@ -92,7 +92,7 @@ class GamepadConfigManager { configs.clear(); if (!j.contains("gamepads") || !j["gamepads"].is_array()) { - return false; // NOLINT(readability-simplify-boolean-expr) + return false; } for (const auto& gamepad_json : j["gamepads"]) { diff --git a/source/core/input/pause_manager.hpp b/source/core/input/pause_manager.hpp index 26eec15..24f7741 100644 --- a/source/core/input/pause_manager.hpp +++ b/source/core/input/pause_manager.hpp @@ -20,11 +20,11 @@ class PauseManager { // --- Operadores friend --- friend auto operator|(Source a, Source b) -> Source { - return static_cast(static_cast(a) | static_cast(b)); // NOLINT(readability-redundant-casting) + return static_cast(static_cast(a) | static_cast(b)); } friend auto operator&(Source a, Source b) -> Source { - return static_cast(static_cast(a) & static_cast(b)); // NOLINT(readability-redundant-casting) + return static_cast(static_cast(a) & static_cast(b)); } friend auto operator~(Source a) -> uint8_t { diff --git a/source/core/rendering/screen.cpp b/source/core/rendering/screen.cpp index b50791d..64997bc 100644 --- a/source/core/rendering/screen.cpp +++ b/source/core/rendering/screen.cpp @@ -218,7 +218,7 @@ void Screen::handleCanvasResized() { // Registra los callbacks nativos de Emscripten que restauran el canvas cuando // SDL3 no emite los events equivalentes. Fuera de Emscripten es un no-op. -void Screen::registerEmscriptenEventCallbacks() { // NOLINT(readability-convert-member-functions-to-static) +void Screen::registerEmscriptenEventCallbacks() { #ifdef __EMSCRIPTEN__ emscripten_set_fullscreenchange_callback(EMSCRIPTEN_EVENT_TARGET_DOCUMENT, nullptr, EM_TRUE, onEmFullscreenChange); emscripten_set_orientationchange_callback(nullptr, EM_TRUE, onEmOrientationChange); diff --git a/source/core/rendering/sdl3gpu/sdl3gpu_shader.cpp b/source/core/rendering/sdl3gpu/sdl3gpu_shader.cpp index 0335477..875f9c4 100644 --- a/source/core/rendering/sdl3gpu/sdl3gpu_shader.cpp +++ b/source/core/rendering/sdl3gpu/sdl3gpu_shader.cpp @@ -429,7 +429,7 @@ namespace Rendering { return shader; } - auto SDL3GPUShader::createShaderSPIRV(SDL_GPUDevice* device, // NOLINT(readability-convert-member-functions-to-static) + auto SDL3GPUShader::createShaderSPIRV(SDL_GPUDevice* device, const uint8_t* spv_code, size_t spv_size, const char* entrypoint, diff --git a/source/core/resources/resource_pack.cpp b/source/core/resources/resource_pack.cpp index 097b37e..6610921 100644 --- a/source/core/resources/resource_pack.cpp +++ b/source/core/resources/resource_pack.cpp @@ -155,7 +155,7 @@ auto ResourcePack::addFile(const std::string& filename, const std::string& filep auto ResourcePack::addDirectory(const std::string& directory) -> bool { if (!std::filesystem::exists(directory)) { std::cerr << "Error: Directory does not exist: " << directory << '\n'; - return false; // NOLINT(readability-simplify-boolean-expr) + return false; } return std::ranges::all_of(std::filesystem::recursive_directory_iterator(directory), diff --git a/source/game/entities/player.cpp b/source/game/entities/player.cpp index fd23675..19cadd0 100644 --- a/source/game/entities/player.cpp +++ b/source/game/entities/player.cpp @@ -890,7 +890,7 @@ void Player::shiftColliders() { } // Pone las texturas del jugador -void Player::setPlayerTextures(const std::vector>& texture) { // NOLINT(readability-named-parameter) +void Player::setPlayerTextures(const std::vector>& texture) { player_sprite_->setTexture(texture[0]); power_sprite_->setTexture(texture[1]); } diff --git a/source/game/entities/player.hpp b/source/game/entities/player.hpp index df612af..09c180a 100644 --- a/source/game/entities/player.hpp +++ b/source/game/entities/player.hpp @@ -132,7 +132,7 @@ class Player { void setAnimation(float delta_time); // Establece la animación según el estado (time-based) // --- Texturas y animaciones --- - void setPlayerTextures(const std::vector>& texture); // NOLINT(readability-avoid-const-params-in-decls) Cambia las texturas del jugador + void setPlayerTextures(const std::vector>& texture); // --- Gameplay: Puntuación y power-ups --- void addScore(int score, int lowest_hi_score_entry); // Añade puntos diff --git a/source/game/options.cpp b/source/game/options.cpp index fcc7512..1bcf73d 100644 --- a/source/game/options.cpp +++ b/source/game/options.cpp @@ -679,7 +679,7 @@ namespace Options { // --- PRIMERA PASADA: Intenta asignar mandos basándose en la ruta guardada --- void GamepadManager::assignGamepadsByPath( const std::array& desired_paths, - const std::vector>& physical_gamepads, // NOLINT(readability-named-parameter) + const std::vector>& physical_gamepads, std::vector>& assigned_instances) { for (size_t i = 0; i < MAX_PLAYERS; ++i) { const std::string& desired_path = desired_paths[i]; @@ -705,7 +705,7 @@ namespace Options { // refrescamos el path guardado al del dispositivo físico actual. void GamepadManager::assignGamepadsByName( const std::array& desired_names, - const std::vector>& physical_gamepads, // NOLINT(readability-named-parameter) + const std::vector>& physical_gamepads, std::vector>& assigned_instances) { for (size_t i = 0; i < MAX_PLAYERS; ++i) { if (gamepads_[i].instance != nullptr) { @@ -731,7 +731,7 @@ namespace Options { // --- TERCERA PASADA: Asigna los mandos físicos restantes a los jugadores libres --- void GamepadManager::assignRemainingGamepads( - const std::vector>& physical_gamepads, // NOLINT(readability-named-parameter) + const std::vector>& physical_gamepads, std::vector>& assigned_instances) { for (size_t i = 0; i < MAX_PLAYERS; ++i) { if (gamepads_[i].instance != nullptr) { @@ -763,7 +763,7 @@ namespace Options { auto GamepadManager::isGamepadAssigned( const std::shared_ptr& physical_gamepad, - const std::vector>& assigned_instances) -> bool { // NOLINT(readability-named-parameter) + const std::vector>& assigned_instances) -> bool { return std::ranges::any_of(assigned_instances, [&physical_gamepad](const auto& assigned) -> auto { return assigned == physical_gamepad; diff --git a/source/game/options.hpp b/source/game/options.hpp index 8c22511..faf8f60 100644 --- a/source/game/options.hpp +++ b/source/game/options.hpp @@ -296,19 +296,19 @@ namespace Options { void assignGamepadsByPath( const std::array& desired_paths, - const std::vector>& physical_gamepads, // NOLINT(readability-avoid-const-params-in-decls) + const std::vector>& physical_gamepads, std::vector>& assigned_instances); void assignGamepadsByName( const std::array& desired_names, - const std::vector>& physical_gamepads, // NOLINT(readability-avoid-const-params-in-decls) + const std::vector>& physical_gamepads, std::vector>& assigned_instances); void assignRemainingGamepads( - const std::vector>& physical_gamepads, // NOLINT(readability-avoid-const-params-in-decls) + const std::vector>& physical_gamepads, std::vector>& assigned_instances); void clearUnassignedGamepadSlots(); [[nodiscard]] static auto isGamepadAssigned( const std::shared_ptr& physical_gamepad, - const std::vector>& assigned_instances) -> bool; // NOLINT(readability-avoid-const-params-in-decls) + const std::vector>& assigned_instances) -> bool; }; struct Keyboard { diff --git a/source/game/ui/menu_renderer.cpp b/source/game/ui/menu_renderer.cpp index 7171372..15daf71 100644 --- a/source/game/ui/menu_renderer.cpp +++ b/source/game/ui/menu_renderer.cpp @@ -380,7 +380,7 @@ void MenuRenderer::updatePosition() { // Resto de métodos (sin cambios significativos) -void MenuRenderer::precalculateMenuWidths(const std::vector>& all_options, const ServiceMenu* menu_state) { // NOLINT(readability-named-parameter) +void MenuRenderer::precalculateMenuWidths(const std::vector>& all_options, const ServiceMenu* menu_state) { std::ranges::fill(group_menu_widths_, ServiceMenu::MIN_WIDTH); for (int group = 0; group < 5; ++group) { auto sg = static_cast(group); diff --git a/source/game/ui/menu_renderer.hpp b/source/game/ui/menu_renderer.hpp index 7859c2e..c7f96a7 100644 --- a/source/game/ui/menu_renderer.hpp +++ b/source/game/ui/menu_renderer.hpp @@ -140,7 +140,7 @@ class MenuRenderer { void updateSwapAnimation(float delta_time); void updatePosition(); - void precalculateMenuWidths(const std::vector>& all_options, const ServiceMenu* menu_state); // NOLINT(readability-avoid-const-params-in-decls) + void precalculateMenuWidths(const std::vector>& all_options, const ServiceMenu* menu_state); [[nodiscard]] auto getMenuWidthForGroup(ServiceMenu::SettingsGroup group) const -> int; [[nodiscard]] auto getAnimatedSelectedColor() const -> Color; void updateColorCounter();