neteja cppcheck (105 → 0)

source/game/gameplay/balloon_formations.cpp

@@ -222,13 +222,13 @@ void BalloonFormations::createFloaterVariants() {
     formations_.resize(100);
 
     // Crear variantes flotantes de las primeras 50 formaciones
-    for (size_t k = 0; k < 50 && k < formations_.size(); k++) {
+    for (size_t k = 0; k < 50; k++) {
+        const auto& source = formations_.at(k).balloons;
         std::vector<SpawnParams> floater_params;
-        floater_params.reserve(formations_.at(k).balloons.size());
-
-        for (const auto& original : formations_.at(k).balloons) {
-            floater_params.emplace_back(original.x, original.y, original.vel_x, Balloon::Type::FLOATER, original.size, original.creation_counter);
-        }
+        floater_params.reserve(source.size());
+        std::ranges::transform(source, std::back_inserter(floater_params), [](const auto& original) {
+            return SpawnParams{original.x, original.y, original.vel_x, Balloon::Type::FLOATER, original.size, original.creation_counter};
+        });
 
         formations_.at(k + 50) = Formation(floater_params);
     }
@@ -395,24 +395,21 @@ void BalloonFormations::loadDefaultPools() {
         }
     }
 
-    // Pool 2: Mix de formaciones normales y floaters (50+)
+    // Pools 2 i 3: requereixen formacions de floaters (>50)
     if (total_formations > 50) {
+        // Pool 2: Mix de formacions normals i floaters
         Pool pool2;
-        // Agregar algunas formaciones básicas
         for (size_t i = 0; i < std::min(static_cast<size_t>(5), total_formations); ++i) {
             pool2.push_back(static_cast<int>(i));
         }
-        // Agregar algunas floaters si existen
         for (size_t i = 50; i < std::min(static_cast<size_t>(55), total_formations); ++i) {
             pool2.push_back(static_cast<int>(i));
         }
         if (!pool2.empty()) {
             pools_.push_back(pool2);
         }
-    }
 
-    // Pool 3: Solo floaters (si existen formaciones 50+)
-    if (total_formations > 50) {
+        // Pool 3: Només floaters
         Pool pool3;
         for (size_t i = 50; i < std::min(static_cast<size_t>(70), total_formations); ++i) {
             pool3.push_back(static_cast<int>(i));