neteja cppcheck (105 → 0)

source/game/gameplay/manage_hiscore_table.cpp

@@ -8,6 +8,7 @@
 #include <iomanip>     // Para std::setw, std::setfill
 #include <iostream>    // Para std::cout
 #include <iterator>    // Para distance
+#include <numeric>     // Para accumulate
 #include <ranges>      // Para __find_if_fn, find_if
 #include <utility>     // Para move
 
@@ -260,22 +261,11 @@ auto ManageHiScoreTable::verifyChecksum(SDL_IOStream* file, const std::string& f
 
 // Calcula checksum de la tabla
 auto ManageHiScoreTable::calculateChecksum(const Table& table) -> unsigned int {
-    unsigned int checksum = 0x12345678;  // Magic seed
-
-    for (const auto& entry : table) {
-        // Checksum del score
+    return std::accumulate(table.begin(), table.end(), 0x12345678U, [](unsigned int checksum, const auto& entry) {
         checksum = ((checksum << 5) + checksum) + static_cast<unsigned int>(entry.score);
-
-        // Checksum del nombre
-        for (char c : entry.name) {
-            checksum = ((checksum << 5) + checksum) + static_cast<unsigned int>(c);
-        }
-
-        // Checksum de one_credit_complete
-        checksum = ((checksum << 5) + checksum) + (entry.one_credit_complete ? 1U : 0U);
-    }
-
-    return checksum;
+        checksum = std::accumulate(entry.name.begin(), entry.name.end(), checksum, [](unsigned int acc, char c) { return ((acc << 5) + acc) + static_cast<unsigned int>(c); });
+        return ((checksum << 5) + checksum) + (entry.one_credit_complete ? 1U : 0U);
+    });
 }
 
 // Guarda la tabla en un fichero