audita NOLINT/cppcheck-suppress: refactor i justifica residuals

source/core/resources/resource_pack.cpp

@@ -157,21 +157,16 @@ auto ResourcePack::addDirectory(const std::string& directory) -> bool {
         return false;
     }
 
-    // cppcheck-suppress useStlAlgorithm
-    for (const auto& entry : std::filesystem::recursive_directory_iterator(directory)) {
-        if (entry.is_regular_file()) {
-            std::string filepath = entry.path().string();
-            std::string filename = std::filesystem::relative(entry.path(), directory).string();
-
-            std::ranges::replace(filename, '\\', '/');
-
-            if (!addFile(filename, filepath)) {
-                return false;
-            }
+    auto iter = std::filesystem::recursive_directory_iterator(directory);
+    return std::all_of(begin(iter), end(iter), [&](const std::filesystem::directory_entry& entry) {
+        if (!entry.is_regular_file()) {
+            return true;
         }
-    }
-
-    return true;
+        std::string filepath = entry.path().string();
+        std::string filename = std::filesystem::relative(entry.path(), directory).string();
+        std::ranges::replace(filename, '\\', '/');
+        return addFile(filename, filepath);
+    });
 }
 
 auto ResourcePack::getResource(const std::string& filename) -> std::vector<uint8_t> {