jaildesigner-jailgames/coffee_crisis_arcade_edition
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 13 Wiki Activity

Pasaeta de cppcheck, ale

Browse Source
This commit is contained in:
Sergio
2024-10-22 09:24:19 +02:00
parent 1d0c2e01a5
commit 5df85e1b1a
28 changed files with 164 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
source/game.cpp
View File

@@ -194,10 +194,12 @@ Game::Game(int player_id, int current_stage, bool demo)
if (demo_.enabled)
{
// Selecciona una pantalla al azar
constexpr auto demos = 3;
const auto demo = rand() % demos;
const int stages[demos] = {0, 3, 5};
current_stage_ = stages[demo];
{
constexpr auto demos = 3;
const auto demo = rand() % demos;
const int stages[demos] = {0, 3, 5};
current_stage_ = stages[demo];
}
// Actualiza el numero de globos explotados según la fase de la demo
for (int i = 0; i < current_stage_; ++i)
@@ -2007,26 +2009,28 @@ void Game::checkPlayersStatusPlaying()
// Obtiene un jugador a partir de su "id"
std::shared_ptr<Player> Game::getPlayer(int id)
{
for (const auto &player : players_)
{
if (player->getId() == id)
{
return player;
}
}
auto it = std::find_if(players_.begin(), players_.end(), [id](const auto &player)
{ return player->getId() == id; });
if (it != players_.end())
{
return *it;
}
return nullptr;
}
// Obtiene un controlador a partir del "id" del jugador
int Game::getController(int player_id)
{
for (int i = 0; i < (int)options.controller.size(); ++i)
auto it = std::find_if(options.controller.begin(), options.controller.end(),
[player_id](const auto &controller)
{
return controller.player_id == player_id;
});
if (it != options.controller.end())
{
if (options.controller[i].player_id == player_id)
{
return i;
}
return std::distance(options.controller.begin(), it);
}
return -1;
@@ -2067,7 +2071,7 @@ void Game::checkPauseInput()
void Game::handleDemoMode()
{
int i = 0;
for (auto &player : players_)
for (const auto &player : players_)
{
if (player->isPlaying())
{
@@ -2119,7 +2123,7 @@ void Game::handleFireInput(const std::shared_ptr<Player> &player, BulletType bul
// Gestiona las entradas de todos los jugadores en el modo normal (fuera del modo demo).
void Game::handlePlayersInput()
{
for (auto &player : players_)
for (const auto &player : players_)
{
if (player->isPlaying())
{