magic numbers: game.cpp

This commit is contained in:
2025-09-19 07:33:27 +02:00
parent 5c82916650
commit af7cb01ead
2 changed files with 7 additions and 6 deletions

View File

@@ -328,16 +328,17 @@ void Game::updateGameStateGameOver(float deltaTime) {
checkBulletCollision();
cleanVectors();
if (game_over_counter_ > 0) {
if (game_over_counter_ >= GAME_OVER_DURATION_MS) {
if (game_over_timer_ > 0) {
if (game_over_timer_ >= GAME_OVER_DURATION_MS) {
createMessage({paths_.at(2), paths_.at(3)}, Resource::get()->getTexture("game_text_game_over"));
Audio::get()->fadeOutMusic(1000);
balloon_manager_->setBouncingSounds(true);
}
game_over_counter_--;
game_over_timer_ -= deltaTime; // Decremento time-based
if (game_over_counter_ == 150) {
constexpr float FADE_TRIGGER_MS = 150.0f * (1000.0f / 60.0f); // 150 frames = 2500ms
if (game_over_timer_ <= FADE_TRIGGER_MS && !fade_out_->isEnabled()) {
fade_out_->activate();
}
}
@@ -2043,7 +2044,7 @@ void Game::handleGameCompletedEvents() {
// Maneja eventos de game over usando flag para trigger único
void Game::handleGameOverEvents() {
static bool game_over_triggered = false;
if (!game_over_triggered && game_over_counter_ >= GAME_OVER_DURATION_MS) {
if (!game_over_triggered && game_over_timer_ >= GAME_OVER_DURATION_MS) {
createMessage({paths_.at(2), paths_.at(3)}, Resource::get()->getTexture("game_text_game_over"));
Audio::get()->fadeOutMusic(1000);
balloon_manager_->setBouncingSounds(true);