fix: resta tidy (60 troballes — empty-catch, widening, branch-clone, etc.)

source/core/audio/audio.cpp

@@ -8,6 +8,7 @@
 // Implementación de stb_vorbis (debe estar ANTES de incluir jail_audio.hpp).
 // clang-format off
 #undef STB_VORBIS_HEADER_ONLY
+// NOLINTNEXTLINE(bugprone-suspicious-include) — stb_vorbis és single-file: el TU principal inclou el .c per portar la implementació.
 #include "external/stb_vorbis.c"
 // stb_vorbis.c filtra les macros L, C i R (i PLAYBACK_*) al TU. Les netegem
 // perquè xocarien amb noms de paràmetres de plantilla en altres headers.

source/core/audio/audio.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <cmath>    // Para std::lround
 #include <cstdint>  // Para int8_t, uint8_t
 #include <string>   // Para string
 #include <utility>  // Para move
@@ -64,8 +65,8 @@ class Audio {
 
     // --- Helpers de conversió per a la capa de presentació ---
     // UI (menús, notificacions) manega enters 0..100; internament viu float 0..1.
-    static constexpr auto toPercent(float volume) -> int {
-        return static_cast<int>(volume * 100.0F + 0.5F);
+    static auto toPercent(float volume) -> int {
+        return static_cast<int>(std::lround(volume * 100.0F));
     }
     static constexpr auto fromPercent(int percent) -> float {
         return static_cast<float>(percent) / 100.0F;

source/core/audio/jail_audio.hpp

@@ -57,12 +57,14 @@ namespace Ja {
         std::unique_ptr<Uint8[], SdlFreeDeleter> buffer;
     };
 
+    // L'ordre (punters primer, ints després, enum de 8 bits al final) minimitza
+    // el padding a 64-bit (evita avisos de clang-analyzer-optin.performance.Padding).
     struct Channel {
         Sound* sound{nullptr};
+        SDL_AudioStream* stream{nullptr};
         int pos{0};
         int times{0};
         int group{0};
-        SDL_AudioStream* stream{nullptr};
         ChannelState state{ChannelState::FREE};
     };
 
@@ -314,7 +316,11 @@ namespace Ja {
         std::fseek(f, 0, SEEK_END);
         const long FSIZE = std::ftell(f);
         std::fseek(f, 0, SEEK_SET);
-        auto* buffer = static_cast<Uint8*>(std::malloc(FSIZE + 1));
+        if (FSIZE <= 0) {
+            std::fclose(f);
+            return nullptr;
+        }
+        auto* buffer = static_cast<Uint8*>(std::malloc(static_cast<size_t>(FSIZE) + 1));
         if (buffer == nullptr) {
             std::fclose(f);
             return nullptr;
@@ -520,7 +526,7 @@ namespace Ja {
     inline auto loadSound(std::uint8_t* buffer, std::uint32_t size) -> Sound* {
         auto sound = std::make_unique<Sound>();
         Uint8* raw = nullptr;
-        if (!SDL_LoadWAV_IO(SDL_IOFromMem(buffer, size), 1, &sound->spec, &raw, &sound->length)) {
+        if (!SDL_LoadWAV_IO(SDL_IOFromMem(buffer, size), true, &sound->spec, &raw, &sound->length)) {
             std::cout << "Failed to load WAV from memory: " << SDL_GetError() << '\n';
             return nullptr;
         }