efbf2457a1
Primera tanda mecánica sobre el lint pendiente. Arregla la causa raíz, no
silencia diagnósticos. Detalle por categoría:
- Uninit members (cppcheck warnings) → inicializadores en declaración:
Bullet (esta_, owner_id_, grace_timer_), Enemy (drotacio_, rotacio_,
esta_, type_, tracking_timer_, ship_position_, tracking_strength_,
direction_change_timer_, timer_invulnerabilitat_), Ship (is_hit_,
invulnerable_timer_), Shape (escala_defecte_) y TitleShip (todos los
miembros del struct, que viven dentro de un std::array<,2>).
- returnByReference (cppcheck performance) → return const T&:
Shape::getName, ResourceLoader::getBasePath. De paso, Shape::get_nom
se renombra a getName y get_num_primitives a getNumPrimitives para
cumplir la convención camelBack del proyecto (lint del .clang-tidy).
- useInitializationList (cppcheck performance) →
Starfield::shape_estrella_ pasa a la lista de inicialización (reordenada
según la declaración para no disparar -Wreorder-ctor).
- noExplicitConstructor (cppcheck style) → explicit en ctores de 1 arg:
Bullet(Renderer*), Enemy(Renderer*), Ship(Renderer*,...) y VectorText(Renderer*).
- variableScope (cppcheck style) → en vector_text.cpp se elimina la
variable 'c' intermedia y se usa el literal '\\xA9' directamente en el
único punto donde se necesita.
- constParameterReference (cppcheck style) → drawScoreboardAnimated pasa
el VectorText por const ref (la API render/renderCentered es const).
- Warnings preexistentes del compilador (resueltos de paso):
- stage_config.hpp: stage_id <= 255 sobre uint8_t era siempre true; se
elimina la comparación redundante y se explica con comentario.
- director.cpp: 'struct stat st = {.st_dev = 0};' disparaba
-Wmissing-field-initializers; pasa a 'struct stat st{};' (zero-init
completo, robusto a las variantes específicas del SO).
- game_scene.cpp: stepDeathSequence devolvía un bool [[nodiscard]] que
el caller ignoraba; el valor era puramente interno. Cambiada la
firma a void.
- cppcheck: añadido --suppress=useStlAlgorithm. Las 26 sugerencias
'Consider using std::any_of/find_if/count_if' son cosméticas y no
aportan claridad sobre las raw loops actuales.
- .clang-tidy de source/core/audio/ eliminado: deshabilitaba todos los
checks en ese subdirectorio por dependencia de jail_audio.hpp, pero
impedía ejecutar 'make tidy' (clang-tidy aborta con "no checks
enabled" al primer archivo del directorio). El proyecto pasa a usar
el mismo patrón de CCAE: solo source/external/ y source/legacy/
quedan fuera del lint.
- lint-reports/ añadido a .gitignore. Carpeta donde 'make tidy' y
'make cppcheck' vuelcan su salida completa para inspección posterior.
Build limpio, cero warnings activos.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
274 lines
9.6 KiB
CMake
274 lines
9.6 KiB
CMake
cmake_minimum_required(VERSION 3.16)
|
|
project(orni VERSION 0.7.2 LANGUAGES CXX)
|
|
|
|
# Info del projecte (font de veritat per a project.h)
|
|
set(PROJECT_LONG_NAME "Orni Attack")
|
|
set(PROJECT_COPYRIGHT "© 2026 JailDesigner")
|
|
|
|
if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
|
|
set(CMAKE_BUILD_TYPE Debug CACHE STRING "" FORCE)
|
|
endif()
|
|
|
|
set(CMAKE_CXX_STANDARD 20)
|
|
set(CMAKE_CXX_STANDARD_REQUIRED ON)
|
|
set(CMAKE_CXX_EXTENSIONS OFF)
|
|
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
|
|
|
|
# --- GENERACIÓ DEL project.h AMB GIT HASH ---
|
|
# Si GIT_HASH ve passat des de fora (Makefile), l'usem; si no, el resolem amb git.
|
|
if(NOT DEFINED GIT_HASH OR GIT_HASH STREQUAL "")
|
|
find_package(Git QUIET)
|
|
if(GIT_FOUND)
|
|
execute_process(
|
|
COMMAND ${GIT_EXECUTABLE} rev-parse --short=7 HEAD
|
|
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
|
|
OUTPUT_VARIABLE GIT_HASH
|
|
OUTPUT_STRIP_TRAILING_WHITESPACE
|
|
ERROR_QUIET
|
|
)
|
|
endif()
|
|
if(NOT DEFINED GIT_HASH OR GIT_HASH STREQUAL "")
|
|
set(GIT_HASH "unknown")
|
|
endif()
|
|
endif()
|
|
|
|
configure_file(${CMAKE_SOURCE_DIR}/source/project.h.in ${CMAKE_BINARY_DIR}/project.h @ONLY)
|
|
|
|
# --- LLISTA DE FONTS (AUTO-DESCOBRIMENT) ---
|
|
# Cerquem tots els .cpp dins core/ i game/, més main.cpp. Exclou legacy/.
|
|
file(GLOB_RECURSE CORE_SOURCES CONFIGURE_DEPENDS "${CMAKE_SOURCE_DIR}/source/core/*.cpp")
|
|
file(GLOB_RECURSE GAME_SOURCES CONFIGURE_DEPENDS "${CMAKE_SOURCE_DIR}/source/game/*.cpp")
|
|
file(GLOB_RECURSE EXTERNAL_SOURCES CONFIGURE_DEPENDS "${CMAKE_SOURCE_DIR}/source/external/*.cpp")
|
|
|
|
set(APP_SOURCES
|
|
${CORE_SOURCES}
|
|
${GAME_SOURCES}
|
|
${EXTERNAL_SOURCES}
|
|
source/main.cpp
|
|
)
|
|
list(FILTER APP_SOURCES EXCLUDE REGEX ".*/legacy/.*")
|
|
|
|
list(LENGTH APP_SOURCES APP_SOURCES_COUNT)
|
|
message(STATUS "Fonts .cpp trobades: ${APP_SOURCES_COUNT}")
|
|
|
|
# --- SDL3 ---
|
|
find_package(SDL3 REQUIRED CONFIG REQUIRED COMPONENTS SDL3)
|
|
|
|
add_executable(${PROJECT_NAME} ${APP_SOURCES})
|
|
|
|
target_include_directories(${PROJECT_NAME} PRIVATE
|
|
"${CMAKE_SOURCE_DIR}/source"
|
|
"${CMAKE_BINARY_DIR}"
|
|
)
|
|
|
|
target_link_libraries(${PROJECT_NAME} PRIVATE SDL3::SDL3)
|
|
|
|
# Silencia warnings de codi de tercers (mateixa filosofia que el
|
|
# .clang-tidy a source/external/). Només afecta aquests TUs concrets;
|
|
# la resta del codi continua compilant amb -Wall -Wextra -Wpedantic.
|
|
if(EXTERNAL_SOURCES)
|
|
set_source_files_properties(
|
|
${EXTERNAL_SOURCES}
|
|
PROPERTIES COMPILE_OPTIONS "-Wno-missing-field-initializers;-Wno-deprecated-declarations"
|
|
)
|
|
endif()
|
|
|
|
target_compile_options(${PROJECT_NAME} PRIVATE -Wall -Wextra -Wpedantic)
|
|
target_compile_options(${PROJECT_NAME} PRIVATE
|
|
$<$<CONFIG:Release>:-O2 -ffunction-sections -fdata-sections>
|
|
)
|
|
|
|
target_compile_definitions(${PROJECT_NAME} PRIVATE
|
|
$<$<CONFIG:Debug>:_DEBUG>
|
|
$<$<CONFIG:Release>:RELEASE_BUILD>
|
|
)
|
|
|
|
if(APPLE AND MACOSX_BUNDLE)
|
|
target_compile_definitions(${PROJECT_NAME} PRIVATE MACOS_BUNDLE)
|
|
endif()
|
|
|
|
if(WIN32)
|
|
target_compile_definitions(${PROJECT_NAME} PRIVATE WINDOWS_BUILD)
|
|
target_link_libraries(${PROJECT_NAME} PRIVATE mingw32)
|
|
target_link_options(${PROJECT_NAME} PRIVATE
|
|
-static-libgcc
|
|
-static-libstdc++
|
|
-static
|
|
)
|
|
elseif(APPLE)
|
|
target_compile_definitions(${PROJECT_NAME} PRIVATE MACOS_BUILD)
|
|
target_compile_options(${PROJECT_NAME} PRIVATE -Wno-deprecated)
|
|
elseif(UNIX AND NOT APPLE)
|
|
target_compile_definitions(${PROJECT_NAME} PRIVATE LINUX_BUILD)
|
|
endif()
|
|
|
|
# --- EINA STANDALONE: pack_resources ---
|
|
# Executable auxiliar que empaqueta `data/` a `build/resources.pack`.
|
|
# EXCLUDE_FROM_ALL: només es compila quan algun target en depèn (ho fa
|
|
# `resource_pack`). Build manual: `cmake --build build --target pack_resources`.
|
|
add_executable(pack_resources EXCLUDE_FROM_ALL
|
|
tools/pack_resources/pack_resources.cpp
|
|
source/core/resources/resource_pack.cpp
|
|
)
|
|
target_include_directories(pack_resources PRIVATE "${CMAKE_SOURCE_DIR}/source")
|
|
target_compile_options(pack_resources PRIVATE -Wall -Wextra -Wpedantic)
|
|
|
|
# --- REGENERACIÓ AUTOMÀTICA DE build/resources.pack ---
|
|
# A cada build re-empaquetem data/ si algun fitxer dins ha canviat. Evita
|
|
# debugar amb un pack obsolet. CONFIGURE_DEPENDS força CMake a re-globbar
|
|
# a la pròxima invocació (recull fitxers nous afegits a data/).
|
|
file(GLOB_RECURSE DATA_FILES CONFIGURE_DEPENDS "${CMAKE_SOURCE_DIR}/data/*")
|
|
set(RESOURCE_PACK "${CMAKE_BINARY_DIR}/resources.pack")
|
|
|
|
add_custom_command(
|
|
OUTPUT ${RESOURCE_PACK}
|
|
COMMAND $<TARGET_FILE:pack_resources>
|
|
"${CMAKE_SOURCE_DIR}/data"
|
|
"${RESOURCE_PACK}"
|
|
DEPENDS pack_resources ${DATA_FILES}
|
|
WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
|
|
COMMENT "Empaquetant data/ → build/resources.pack"
|
|
VERBATIM
|
|
)
|
|
add_custom_target(resource_pack ALL DEPENDS ${RESOURCE_PACK})
|
|
add_dependencies(${PROJECT_NAME} resource_pack)
|
|
|
|
# --- COMPILACIÓ DE SHADERS GLSL → SPIR-V ---
|
|
# Compila tots els shaders .glsl a SPIR-V (Vulkan/Linux/Windows).
|
|
# macOS necessitarà MSL en el futur (Metal) — es generen amb spirv-cross
|
|
# o glslang amb target distint en una etapa posterior.
|
|
# Sortida: build/shaders/*.spv
|
|
find_program(GLSLC_EXE NAMES glslc HINTS ${Vulkan_GLSLC_EXECUTABLE})
|
|
if(GLSLC_EXE)
|
|
file(GLOB SHADER_SOURCES CONFIGURE_DEPENDS "${CMAKE_SOURCE_DIR}/shaders/*.glsl")
|
|
set(COMPILED_SHADERS "")
|
|
foreach(SHADER ${SHADER_SOURCES})
|
|
get_filename_component(SHADER_NAME ${SHADER} NAME)
|
|
# Detectar stage del nom: line.vert.glsl → vert, line.frag.glsl → frag
|
|
if(SHADER_NAME MATCHES "\\.vert\\.glsl$")
|
|
set(SHADER_STAGE "vert")
|
|
string(REPLACE ".glsl" ".spv" SPV_NAME ${SHADER_NAME})
|
|
elseif(SHADER_NAME MATCHES "\\.frag\\.glsl$")
|
|
set(SHADER_STAGE "frag")
|
|
string(REPLACE ".glsl" ".spv" SPV_NAME ${SHADER_NAME})
|
|
else()
|
|
message(WARNING "Shader sense stage detectat: ${SHADER_NAME} (esperat .vert.glsl o .frag.glsl)")
|
|
continue()
|
|
endif()
|
|
set(SPV_OUTPUT "${CMAKE_BINARY_DIR}/shaders/${SPV_NAME}")
|
|
add_custom_command(
|
|
OUTPUT ${SPV_OUTPUT}
|
|
COMMAND ${CMAKE_COMMAND} -E make_directory "${CMAKE_BINARY_DIR}/shaders"
|
|
COMMAND ${GLSLC_EXE} -fshader-stage=${SHADER_STAGE} -O ${SHADER} -o ${SPV_OUTPUT}
|
|
DEPENDS ${SHADER}
|
|
COMMENT "Compilant shader ${SHADER_NAME} → ${SPV_NAME}"
|
|
VERBATIM
|
|
)
|
|
list(APPEND COMPILED_SHADERS ${SPV_OUTPUT})
|
|
endforeach()
|
|
add_custom_target(shaders ALL DEPENDS ${COMPILED_SHADERS})
|
|
add_dependencies(${PROJECT_NAME} shaders)
|
|
message(STATUS "Shaders trobats: ${SHADER_SOURCES}")
|
|
else()
|
|
message(FATAL_ERROR "glslc no trobat: instal·la 'shaderc' o 'vulkan-sdk' per compilar shaders SPIR-V")
|
|
endif()
|
|
|
|
# --- STATIC ANALYSIS / FORMAT TARGETS ---
|
|
find_program(CLANG_TIDY_EXE NAMES clang-tidy)
|
|
find_program(CLANG_FORMAT_EXE NAMES clang-format)
|
|
find_program(CPPCHECK_EXE NAMES cppcheck)
|
|
|
|
file(GLOB_RECURSE ALL_SOURCE_FILES
|
|
"${CMAKE_SOURCE_DIR}/source/*.cpp"
|
|
"${CMAKE_SOURCE_DIR}/source/*.hpp"
|
|
"${CMAKE_SOURCE_DIR}/source/*.h"
|
|
)
|
|
list(FILTER ALL_SOURCE_FILES EXCLUDE REGEX ".*/external/.*")
|
|
list(FILTER ALL_SOURCE_FILES EXCLUDE REGEX ".*/legacy/.*")
|
|
|
|
set(CPPCHECK_SOURCES ${ALL_SOURCE_FILES})
|
|
list(FILTER CPPCHECK_SOURCES INCLUDE REGEX ".*\\.cpp$")
|
|
|
|
if(CLANG_TIDY_EXE)
|
|
# En macOS, obtenir la ruta del SDK perquè clang-tidy trobe els headers del sistema.
|
|
set(CLANG_TIDY_EXTRA_ARGS "")
|
|
if(APPLE)
|
|
execute_process(
|
|
COMMAND xcrun --show-sdk-path
|
|
OUTPUT_VARIABLE MACOS_SDK_PATH
|
|
OUTPUT_STRIP_TRAILING_WHITESPACE
|
|
)
|
|
if(MACOS_SDK_PATH)
|
|
set(CLANG_TIDY_EXTRA_ARGS "--extra-arg=-isysroot${MACOS_SDK_PATH}")
|
|
message(STATUS "clang-tidy usarà SDK de macOS: ${MACOS_SDK_PATH}")
|
|
endif()
|
|
endif()
|
|
|
|
add_custom_target(tidy
|
|
COMMAND ${CLANG_TIDY_EXE}
|
|
-p ${CMAKE_BINARY_DIR}
|
|
${CLANG_TIDY_EXTRA_ARGS}
|
|
${ALL_SOURCE_FILES}
|
|
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
|
|
COMMENT "Running clang-tidy..."
|
|
)
|
|
|
|
add_custom_target(tidy-fix
|
|
COMMAND ${CLANG_TIDY_EXE}
|
|
-p ${CMAKE_BINARY_DIR}
|
|
${CLANG_TIDY_EXTRA_ARGS}
|
|
--fix
|
|
${ALL_SOURCE_FILES}
|
|
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
|
|
COMMENT "Running clang-tidy with fixes..."
|
|
)
|
|
else()
|
|
message(STATUS "clang-tidy no trobat - targets 'tidy' i 'tidy-fix' no disponibles")
|
|
endif()
|
|
|
|
if(CLANG_FORMAT_EXE)
|
|
add_custom_target(format
|
|
COMMAND ${CLANG_FORMAT_EXE}
|
|
-i
|
|
${ALL_SOURCE_FILES}
|
|
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
|
|
COMMENT "Running clang-format..."
|
|
)
|
|
|
|
add_custom_target(format-check
|
|
COMMAND ${CLANG_FORMAT_EXE}
|
|
--dry-run
|
|
--Werror
|
|
${ALL_SOURCE_FILES}
|
|
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
|
|
COMMENT "Checking clang-format..."
|
|
)
|
|
else()
|
|
message(STATUS "clang-format no trobat - targets 'format' i 'format-check' no disponibles")
|
|
endif()
|
|
|
|
if(CPPCHECK_EXE)
|
|
add_custom_target(cppcheck
|
|
COMMAND ${CPPCHECK_EXE}
|
|
--enable=warning,style,performance,portability
|
|
--std=c++20
|
|
--language=c++
|
|
--inline-suppr
|
|
--suppress=missingIncludeSystem
|
|
--suppress=toomanyconfigs
|
|
--suppress=*:*source/external/*
|
|
--suppress=*:*source/legacy/*
|
|
--suppress=normalCheckLevelMaxBranches
|
|
--suppress=useStlAlgorithm
|
|
-D_DEBUG
|
|
-DLINUX_BUILD
|
|
--quiet
|
|
-I ${CMAKE_SOURCE_DIR}/source
|
|
${CPPCHECK_SOURCES}
|
|
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
|
|
COMMENT "Running cppcheck..."
|
|
)
|
|
else()
|
|
message(STATUS "cppcheck no trobat - target 'cppcheck' no disponible")
|
|
endif()
|