diff --git a/source/core/rendering/pixel_reveal.cpp b/source/core/rendering/pixel_reveal.cpp index 8beec6e..a5754f7 100644 --- a/source/core/rendering/pixel_reveal.cpp +++ b/source/core/rendering/pixel_reveal.cpp @@ -66,7 +66,7 @@ PixelReveal::PixelReveal(int width, int height, float pixels_per_second, float s } // Actualiza el estado del revelado -void PixelReveal::update(float time_active) { // NOLINT(readability-make-member-function-const) +void PixelReveal::update(float time_active) { // En modo normal revela (pone transparente); en modo inverso cubre (pone negro) const auto PIXEL_COLOR = reverse_ ? 0 : 255; diff --git a/source/core/rendering/screen.cpp b/source/core/rendering/screen.cpp index 83cef7c..0735d37 100644 --- a/source/core/rendering/screen.cpp +++ b/source/core/rendering/screen.cpp @@ -808,7 +808,7 @@ auto Screen::initSDLVideo() -> bool { // Registra los callbacks nativos de Emscripten que restauran el canvas cuando // SDL3 no emite los events equivalentes. Fuera de Emscripten es un no-op. -void Screen::registerEmscriptenEventCallbacks() { // NOLINT(readability-convert-member-functions-to-static) +void Screen::registerEmscriptenEventCallbacks() { #ifdef __EMSCRIPTEN__ // NO registramos resize callback. En móvil, el scroll hace que el navegador // oculte/muestre la barra de URL, disparando un resize del DOM por cada scroll, diff --git a/source/core/rendering/surface.cpp b/source/core/rendering/surface.cpp index f64f078..9ecbd5b 100644 --- a/source/core/rendering/surface.cpp +++ b/source/core/rendering/surface.cpp @@ -148,14 +148,14 @@ void Surface::setColor(int index, Uint32 color) { } // Rellena la superficie con un color -void Surface::clear(Uint8 color) { // NOLINT(readability-convert-member-functions-to-static) +void Surface::clear(Uint8 color) { const size_t TOTAL_PIXELS = static_cast(surface_data_->width) * static_cast(surface_data_->height); Uint8* data_ptr = surface_data_->data.get(); std::fill(data_ptr, data_ptr + TOTAL_PIXELS, color); } // Pone un pixel en la SurfaceData -void Surface::putPixel(int x, int y, Uint8 color) { // NOLINT(readability-convert-member-functions-to-static) +void Surface::putPixel(int x, int y, Uint8 color) { if (x < 0 || y < 0 || x >= surface_data_->width || y >= surface_data_->height) { return; // Coordenadas fuera de rango } @@ -168,7 +168,7 @@ void Surface::putPixel(int x, int y, Uint8 color) { // NOLINT(readability-conve auto Surface::getPixel(int x, int y) -> Uint8 { return surface_data_->data.get()[x + (y * surface_data_->width)]; } // Dibuja un rectangulo relleno -void Surface::fillRect(const SDL_FRect* rect, Uint8 color) { // NOLINT(readability-convert-member-functions-to-static) +void Surface::fillRect(const SDL_FRect* rect, Uint8 color) { // Limitar los valores del rectángulo al tamaño de la superficie float x_start = std::max(0.0F, rect->x); float y_start = std::max(0.0F, rect->y); @@ -185,7 +185,7 @@ void Surface::fillRect(const SDL_FRect* rect, Uint8 color) { // NOLINT(readabil } // Dibuja el borde de un rectangulo -void Surface::drawRectBorder(const SDL_FRect* rect, Uint8 color) { // NOLINT(readability-convert-member-functions-to-static) +void Surface::drawRectBorder(const SDL_FRect* rect, Uint8 color) { // Limitar los valores del rectángulo al tamaño de la superficie float x_start = std::max(0.0F, rect->x); float y_start = std::max(0.0F, rect->y); @@ -212,7 +212,7 @@ void Surface::drawRectBorder(const SDL_FRect* rect, Uint8 color) { // NOLINT(re } // Dibuja una linea (Bresenham en enteros) -void Surface::drawLine(float x1, float y1, float x2, float y2, Uint8 color) { // NOLINT(readability-convert-member-functions-to-static) +void Surface::drawLine(float x1, float y1, float x2, float y2, Uint8 color) { int ix1 = static_cast(std::lround(x1)); int iy1 = static_cast(std::lround(y1)); const int IX2 = static_cast(std::lround(x2)); @@ -247,7 +247,7 @@ void Surface::drawLine(float x1, float y1, float x2, float y2, Uint8 color) { / } } -void Surface::render(int x, int y, SDL_FRect* src_rect, SDL_FlipMode flip) { // NOLINT(readability-make-member-function-const) +void Surface::render(int x, int y, SDL_FRect* src_rect, SDL_FlipMode flip) { auto surface_data_dest = Screen::get()->getRendererSurface()->getSurfaceData(); // Aplicar render offset (usado por transiciones entre pantallas) @@ -533,7 +533,7 @@ void Surface::toARGBBuffer(Uint32* buffer) const { } // Vuelca la superficie a una textura -void Surface::copyToTexture(SDL_Renderer* renderer, SDL_Texture* texture) { // NOLINT(readability-convert-member-functions-to-static) +void Surface::copyToTexture(SDL_Renderer* renderer, SDL_Texture* texture) { if ((renderer == nullptr) || (texture == nullptr) || !surface_data_) { throw std::runtime_error("Renderer or texture is null."); } @@ -575,7 +575,7 @@ void Surface::copyToTexture(SDL_Renderer* renderer, SDL_Texture* texture) { // } // Vuelca la superficie a una textura -void Surface::copyToTexture(SDL_Renderer* renderer, SDL_Texture* texture, SDL_FRect* src_rect, SDL_FRect* dest_rect) { // NOLINT(readability-convert-member-functions-to-static) +void Surface::copyToTexture(SDL_Renderer* renderer, SDL_Texture* texture, SDL_FRect* src_rect, SDL_FRect* dest_rect) { if ((renderer == nullptr) || (texture == nullptr) || !surface_data_) { throw std::runtime_error("Renderer or texture is null."); } @@ -624,7 +624,7 @@ void Surface::copyToTexture(SDL_Renderer* renderer, SDL_Texture* texture, SDL_FR } // Realiza un efecto de fundido en la paleta principal -auto Surface::fadePalette() -> bool { // NOLINT(readability-convert-member-functions-to-static) +auto Surface::fadePalette() -> bool { static constexpr int PALETTE_SIZE = 19; static_assert(std::tuple_size_v >= PALETTE_SIZE, "Palette size is insufficient for fadePalette operation."); @@ -641,7 +641,7 @@ auto Surface::fadePalette() -> bool { // NOLINT(readability-convert-member-func } // Realiza un efecto de fundido en la paleta secundaria -auto Surface::fadeSubPalette(Uint32 delay) -> bool { // NOLINT(readability-convert-member-functions-to-static) +auto Surface::fadeSubPalette(Uint32 delay) -> bool { // Variable estática para almacenar el último tick static Uint32 last_tick_ = 0; @@ -672,4 +672,4 @@ auto Surface::fadeSubPalette(Uint32 delay) -> bool { // NOLINT(readability-conv } // Restaura la sub paleta a su estado original -void Surface::resetSubPalette() { initializeSubPalette(sub_palette_); } // NOLINT(readability-convert-member-functions-to-static) +void Surface::resetSubPalette() { initializeSubPalette(sub_palette_); } diff --git a/source/core/rendering/text.cpp b/source/core/rendering/text.cpp index 20540a6..bf641fd 100644 --- a/source/core/rendering/text.cpp +++ b/source/core/rendering/text.cpp @@ -167,7 +167,7 @@ void Text::write(int x, int y, const std::string& text, int kerning, int lenght) } // Escribe el texto en una surface -auto Text::writeToSurface(const std::string& text, int zoom, int kerning) -> std::shared_ptr { // NOLINT(readability-make-member-function-const) +auto Text::writeToSurface(const std::string& text, int zoom, int kerning) -> std::shared_ptr { auto width = length(text, kerning) * zoom; auto height = box_height_ * zoom; auto surface = std::make_shared(width, height); @@ -181,7 +181,7 @@ auto Text::writeToSurface(const std::string& text, int zoom, int kerning) -> std } // Escribe el texto con extras en una surface -auto Text::writeDXToSurface(Uint8 flags, const std::string& text, int kerning, Uint8 text_color, Uint8 shadow_distance, Uint8 shadow_color, int lenght) -> std::shared_ptr { // NOLINT(readability-make-member-function-const) +auto Text::writeDXToSurface(Uint8 flags, const std::string& text, int kerning, Uint8 text_color, Uint8 shadow_distance, Uint8 shadow_color, int lenght) -> std::shared_ptr { auto width = Text::length(text, kerning) + shadow_distance; auto height = box_height_ + shadow_distance; auto surface = std::make_shared(width, height); diff --git a/source/core/resources/resource_loader.cpp b/source/core/resources/resource_loader.cpp index f56a4e6..3b30fcf 100644 --- a/source/core/resources/resource_loader.cpp +++ b/source/core/resources/resource_loader.cpp @@ -53,7 +53,7 @@ namespace Resource { } // Load a resource - auto Loader::loadResource(const std::string& filename) -> std::vector { // NOLINT(readability-make-member-function-const) + auto Loader::loadResource(const std::string& filename) -> std::vector { if (!initialized_) { std::cerr << "Loader: Not initialized\n"; return {}; @@ -81,7 +81,7 @@ namespace Resource { } // Check if a resource exists - auto Loader::resourceExists(const std::string& filename) -> bool { // NOLINT(readability-make-member-function-const) + auto Loader::resourceExists(const std::string& filename) -> bool { if (!initialized_) { return false; } @@ -158,7 +158,7 @@ namespace Resource { if (checksum == 0) { std::cerr << "Loader: Pack checksum is zero (invalid)\n"; - return false; // NOLINT(readability-simplify-boolean-expr) + return false; } std::cout << "Loader: Pack checksum: 0x" << std::hex << checksum << std::dec diff --git a/source/core/system/debug.cpp b/source/core/system/debug.cpp index 1b13369..820e076 100644 --- a/source/core/system/debug.cpp +++ b/source/core/system/debug.cpp @@ -32,7 +32,7 @@ auto Debug::get() -> Debug* { } // Dibuja en pantalla -void Debug::render() { // NOLINT(readability-make-member-function-const) +void Debug::render() { auto text = Resource::Cache::get()->getText("aseprite"); int y = y_; int w = 0; diff --git a/source/game/entities/path_enemy.cpp b/source/game/entities/path_enemy.cpp index c714559..7df3472 100644 --- a/source/game/entities/path_enemy.cpp +++ b/source/game/entities/path_enemy.cpp @@ -38,7 +38,7 @@ void PathEnemy::resetToInitialPosition(const Data& data) { #endif // Comprueba si ha llegado al limite del recorrido para darse media vuelta -void PathEnemy::checkPath() { // NOLINT(readability-make-member-function-const) +void PathEnemy::checkPath() { if (sprite_->getPosX() > x2_ || sprite_->getPosX() < x1_) { // Recoloca if (sprite_->getPosX() > x2_) { diff --git a/source/game/entities/player.cpp b/source/game/entities/player.cpp index f221b62..02f40bf 100644 --- a/source/game/entities/player.cpp +++ b/source/game/entities/player.cpp @@ -632,7 +632,7 @@ void Player::placeSprite() { sprite_->setPos(x_, y_); } -void Player::animate(float delta_time) { // NOLINT(readability-make-member-function-const) +void Player::animate(float delta_time) { if (state_ == State::ON_AIR) { turning_ = false; const bool NEAR_PEAK = vy_ > JUMP_VELOCITY * 0.5F && vy_ < -JUMP_VELOCITY * 0.5F; diff --git a/source/game/gameplay/room.cpp b/source/game/gameplay/room.cpp index c915a01..cdf0cc0 100644 --- a/source/game/gameplay/room.cpp +++ b/source/game/gameplay/room.cpp @@ -219,7 +219,7 @@ void Room::setBgColor(Uint8 bg_color) { #endif // Actualiza las variables y objetos de la habitación -void Room::update(float delta_time) { // NOLINT(readability-make-member-function-const) +void Room::update(float delta_time) { if (is_paused_) { // Si está en modo pausa no se actualiza nada return; diff --git a/source/game/gameplay/room_format.hpp b/source/game/gameplay/room_format.hpp index da7fcce..94f72e7 100644 --- a/source/game/gameplay/room_format.hpp +++ b/source/game/gameplay/room_format.hpp @@ -69,7 +69,7 @@ class RoomFormat { // --- Parsing helpers (siempre disponibles, los usa loadYAML) --- static auto convertRoomConnection(const std::string& value) -> std::string; static auto convertAutoSurface(const fkyaml::node& node) -> int; - static auto flattenTilemap(const std::vector>& tilemap_2d) -> std::vector; // NOLINT(readability-avoid-const-params-in-decls) + static auto flattenTilemap(const std::vector>& tilemap_2d) -> std::vector; static void parseRoomConfig(const fkyaml::node& yaml, Room::Data& room, const std::string& file_name); static void parseRoomConnections(const fkyaml::node& conn_node, Room::Data& room); static void parseTilemap(const fkyaml::node& yaml, Room::Data& room, const std::string& file_name, bool verbose); diff --git a/source/game/gameplay/room_tracker.cpp b/source/game/gameplay/room_tracker.cpp index 199b150..ac7e98b 100644 --- a/source/game/gameplay/room_tracker.cpp +++ b/source/game/gameplay/room_tracker.cpp @@ -13,7 +13,7 @@ auto RoomTracker::addRoom(const std::string& name) -> bool { if (!hasBeenVisited(name)) { // En caso contrario añádela a la lista rooms_.push_back(name); - return true; // NOLINT(readability-simplify-boolean-expr) + return true; } return false;