cppcheck

source/core/audio/jail_audio.hpp

@@ -265,13 +265,13 @@ inline JA_Music_t* JA_LoadMusic(const Uint8* buffer, Uint32 length) {
     auto* music = new JA_Music_t();
     music->ogg_data.assign(buffer, buffer + length);
 
-    int error = 0;
+    int vorbis_error = 0;
     music->vorbis = stb_vorbis_open_memory(music->ogg_data.data(),
         static_cast<int>(length),
-        &error,
+        &vorbis_error,
         nullptr);
     if (!music->vorbis) {
-        std::cout << "JA_LoadMusic: stb_vorbis_open_memory failed (error " << error << ")" << '\n';
+        std::cout << "JA_LoadMusic: stb_vorbis_open_memory failed (error " << vorbis_error << ")" << '\n';
         delete music;
         return nullptr;
     }

source/core/jail/jdraw8.cpp

@@ -40,8 +40,11 @@ void JD8_ClearScreen(Uint8 color) {
 }
 
 JD8_Surface JD8_NewSurface() {
-    JD8_Surface surface = (JD8_Surface)malloc(64000);
-    memset(surface, 0, 64000);
+    JD8_Surface surface = (JD8_Surface)calloc(1, 64000);
+    if (surface == NULL) {
+        printf("JD8_NewSurface: out of memory\n");
+        exit(1);
+    }
     return surface;
 }
 
@@ -89,6 +92,10 @@ JD8_Palette JD8_LoadPalette(const char* file) {
             // d'alliberar amb free() — mateixa convenció que el LoadPalette
             // original (retornava un malloc).
             JD8_Palette palette = (JD8_Palette)malloc(768);
+            if (palette == NULL) {
+                printf("JD8_LoadPalette: out of memory\n");
+                exit(1);
+            }
             memcpy(palette, cached.data(), 768);
             return palette;
         } catch (const std::exception&) {

source/core/jail/jfile.cpp

@@ -82,9 +82,7 @@ void file_setconfigfolder(const char* foldername) {
     config_folder = std::string(homedir) + "/.config/" + foldername;
 #endif
 
-    if (!config_folder.empty()) {
-        std::filesystem::create_directories(config_folder);
-    }
+    std::filesystem::create_directories(config_folder);
 }
 
 const char* file_getconfigfolder() {

source/core/rendering/text.cpp

@@ -80,27 +80,27 @@ void Text::loadFont(const char* fnt_file) {
         // Elimina comentaris inline
         auto comment_pos = line.find('#');
         if (comment_pos != std::string::npos) {
-            line = line.substr(0, comment_pos);
+            line.resize(comment_pos);
         }
 
         // Parseja directives
-        if (line.find("box_width") == 0) {
+        if (line.starts_with("box_width")) {
             sscanf(line.c_str(), "box_width %d", &box_width_);
             continue;
         }
-        if (line.find("box_height") == 0) {
+        if (line.starts_with("box_height")) {
             sscanf(line.c_str(), "box_height %d", &box_height_);
             continue;
         }
-        if (line.find("columns") == 0) {
+        if (line.starts_with("columns")) {
             sscanf(line.c_str(), "columns %d", &columns_);
             continue;
         }
-        if (line.find("cell_spacing") == 0) {
+        if (line.starts_with("cell_spacing")) {
             sscanf(line.c_str(), "cell_spacing %d", &cell_spacing_);
             continue;
         }
-        if (line.find("row_spacing") == 0) {
+        if (line.starts_with("row_spacing")) {
             sscanf(line.c_str(), "row_spacing %d", &row_spacing_);
             continue;
         }