refactor: file_getfilebuffer → file_readfile (std::vector<char>) — elimina 3 leaks (paleta + música gameplay + música cinemàtica)

source/core/jail/jfile.cpp

@@ -147,12 +147,12 @@ FILE* file_getfilepointer(const char* resourcename, int& filesize, const bool bi
     return f;
 }
 
-char* file_getfilebuffer(const char* resourcename, int& filesize, const bool zero_terminate) {
+std::vector<char> file_readfile(const char* resourcename) {
+    int filesize = 0;
     FILE* f = file_getfilepointer(resourcename, filesize, true);
-    if (!f) return nullptr;
-    char* buffer = static_cast<char*>(malloc(zero_terminate ? filesize + 1 : filesize));
-    fread(buffer, filesize, 1, f);
-    if (zero_terminate) buffer[filesize] = 0;
+    if (!f) return {};
+    std::vector<char> buffer(filesize);
+    fread(buffer.data(), filesize, 1, f);
     fclose(f);
     return buffer;
 }