jaildesigner-jailgames/jaildoctors-dilemma
1
0
Fork 2
Code Issues Pull Requests Projects Releases 24 Wiki Activity

elimina NOLINTs petits obsolets; justifica el residual de CallAndMessage

Browse Source
This commit is contained in:
Sergio Valor
2026-05-17 18:30:37 +02:00
parent 3228647738
commit 418df568a1
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/game/gameplay/room_loader.cpp
+1 -1
View File
@@ -39,7 +39,7 @@ auto RoomLoader::convertAutoSurface(const fkyaml::node& node) -> int {
} }
// Convierte un tilemap 2D a vector 1D flat // Convierte un tilemap 2D a vector 1D flat
auto RoomLoader::flattenTilemap(const std::vector<std::vector<int>>& tilemap_2d) -> std::vector<int> { // NOLINT(readability-named-parameter) auto RoomLoader::flattenTilemap(const std::vector<std::vector<int>>& tilemap_2d) -> std::vector<int> {
std::vector<int> tilemap_flat; std::vector<int> tilemap_flat;
tilemap_flat.reserve(512); // 16 rows × 32 cols tilemap_flat.reserve(512); // 16 rows × 32 cols
source/game/scenes/title.cpp
+1 -1
View File
@@ -51,7 +51,7 @@ Title::Title()
} }
// Destructor // Destructor
Title::~Title() { // NOLINT(modernize-use-equals-default) Title::~Title() {
loading_screen_surface_->resetSubPalette(); loading_screen_surface_->resetSubPalette();
title_surface_->resetSubPalette(); title_surface_->resetSubPalette();
} }
source/game/ui/console_commands.cpp
+4 -2
View File
@@ -143,8 +143,10 @@ static auto applyPreset(const std::vector<std::string>& args) -> std::string {
if (COUNT == 0) { return "No " + SHADER_LABEL + " presets available"; } if (COUNT == 0) { return "No " + SHADER_LABEL + " presets available"; }
const auto PRESET_NAME = [&]() -> std::string { const auto PRESET_NAME = [&]() -> std::string {
const auto& name = IS_CRTPI ? presets_crtpi[static_cast<size_t>(current_idx)].name // NOLINT(clang-analyzer-core.CallAndMessage) // NOLINTBEGIN(clang-analyzer-core.CallAndMessage): fals positiu — l'analitzador no veu que el guard `if (COUNT == 0) return ...` (línia 143) garanteix que el vector no està buit, així que current_idx és un índex vàlid
: presets_postfx[static_cast<size_t>(current_idx)].name; // NOLINT(clang-analyzer-core.CallAndMessage) const auto& name = IS_CRTPI ? presets_crtpi[static_cast<size_t>(current_idx)].name
: presets_postfx[static_cast<size_t>(current_idx)].name;
// NOLINTEND(clang-analyzer-core.CallAndMessage)
return prettyName(name); return prettyName(name);
}; };