manuals tidy tier 2: empty-catch, enum-size, trivially-destructible

source/game/scenes/banner_scene.hpp

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <cstdint>
+
 #include "game/scenes/palette_fade.hpp"
 #include "game/scenes/scene.hpp"
 #include "game/scenes/surface_handle.hpp"
@@ -26,7 +28,7 @@ namespace scenes {
         [[nodiscard]] auto nextState() const -> int override { return 0; }
 
        private:
-        enum class Phase { FadingIn,
+        enum class Phase : std::uint8_t { FadingIn,
             Showing,
             FadingOut,
             Done };

source/game/scenes/credits_scene.hpp

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <cstdint>
+
 #include "core/jail/jdraw8.hpp"
 #include "game/scenes/frame_animator.hpp"
 #include "game/scenes/palette_fade.hpp"
@@ -31,7 +33,7 @@ namespace scenes {
         [[nodiscard]] auto done() const -> bool override { return phase_ == Phase::Done; }
 
        private:
-        enum class Phase { Rolling,
+        enum class Phase : std::uint8_t { Rolling,
             FadingOut,
             Done };
 

source/game/scenes/intro_new_logo_scene.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <cstdint>
 #include <memory>
 
 #include "core/jail/jdraw8.hpp"
@@ -39,7 +40,7 @@ namespace scenes {
         [[nodiscard]] auto done() const -> bool override { return phase_ == Phase::Done; }
 
        private:
-        enum class Phase {
+        enum class Phase : std::uint8_t {
             Initial,        // pantalla negra 1000 ms
             Revealing,      // 9 × 2 frames × 150 ms cada un
             FullLogoFlash,  // logo complet + cursor, 200 ms

source/game/scenes/intro_scene.hpp

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <cstdint>
 #include <memory>
 
 #include "core/jail/jdraw8.hpp"
@@ -40,7 +41,7 @@ namespace scenes {
         [[nodiscard]] auto done() const -> bool override { return phase_ == Phase::Done; }
 
        private:
-        enum class Phase {
+        enum class Phase : std::uint8_t {
             InitialWait,   // 1000 ms pantalla negra
             Reveal,        // 15 passos del wordmark
             PaletteCycle,  // 256 × 20 ms mutant pal[16..31]

source/game/scenes/menu_scene.hpp

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <cstdint>
+
 #include "game/scenes/frame_animator.hpp"
 #include "game/scenes/palette_fade.hpp"
 #include "game/scenes/scene.hpp"
@@ -29,7 +31,7 @@ namespace scenes {
         [[nodiscard]] auto done() const -> bool override { return phase_ == Phase::Done; }
 
        private:
-        enum class Phase { FadingIn,
+        enum class Phase : std::uint8_t { FadingIn,
             Showing,
             FadingOut,
             Done };

source/game/scenes/mort_scene.hpp

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <cstdint>
+
 #include "game/scenes/palette_fade.hpp"
 #include "game/scenes/scene.hpp"
 #include "game/scenes/surface_handle.hpp"
@@ -21,7 +23,7 @@ namespace scenes {
         [[nodiscard]] auto done() const -> bool override { return phase_ == Phase::Done; }
 
        private:
-        enum class Phase { FadingIn,
+        enum class Phase : std::uint8_t { FadingIn,
             Showing,
             FadingOut,
             Done };

source/game/scenes/secreta_scene.hpp

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <cstdint>
+
 #include "core/jail/jdraw8.hpp"
 #include "game/scenes/palette_fade.hpp"
 #include "game/scenes/scene.hpp"
@@ -35,7 +37,7 @@ namespace scenes {
         [[nodiscard]] auto nextState() const -> int override { return 0; }
 
        private:
-        enum class Phase {
+        enum class Phase : std::uint8_t {
             InitialFadeOut,
             Tomba1ScrollIn,
             Tomba1Hold,

source/game/scenes/slides_scene.hpp

@@ -1,5 +1,7 @@
 #pragma once
 
+#include <cstdint>
+
 #include "core/jail/jdraw8.hpp"
 #include "game/scenes/palette_fade.hpp"
 #include "game/scenes/scene.hpp"
@@ -44,7 +46,7 @@ namespace scenes {
         [[nodiscard]] auto nextState() const -> int override { return next_state_; }
 
        private:
-        enum class Phase {
+        enum class Phase : std::uint8_t {
             Slide1Enter,
             Slide1Hold,
             FadeOut1,